Add HID support for macOS #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you for this. However, I'm encountering a particular issue in both EDIT: For some reason this does not happen all the time. Although this seems to be a pretty consistent issue in |
On macOS, SDL relative mouse mode does not work correctly when the cursor is outside the window. As a workaround, move the cursor inside the window before setting the relative mouse mode. Refs SDL/#5340 <libsdl-org/SDL#5340> PR #3031 <#3031>
|
Thank you for your tests 👍 Noted for the remaining bug. At least the "double cursor" issue has a workaround, this one looks minor. I merge and hopefully everything will be fixed in libusb in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build with libusb on macOS to enable HID/OTG features.
Due to a bug in SDL (libsdl-org/SDL#5340) related to relative mouse mode, implement a workaround to capture the mouse correctly (and avoid double mouse cursors).
Fixes #2774
Tests welcome.
FYI, Windows support (for OTG only) will be provided by #3011.