Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Continuous Integration Using GitHub Actions #1709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dylanmtaylor
Copy link

@dylanmtaylor dylanmtaylor commented Aug 26, 2020

This pull request leverages GitHub Actions to automatically build scrcpy on every commit or pull request.

@dylanmtaylor dylanmtaylor changed the title WIP: Implement CI/CD for scrcpy Implement Continuous Integration Using GitHub Actions Aug 26, 2020
@dylanmtaylor dylanmtaylor force-pushed the actions-ci branch 2 times, most recently from 89333e9 to 8300294 Compare August 26, 2020 02:27
@dylanmtaylor
Copy link
Author

This is ready for review, it seems to work well. Please take a look and let me know what you think.

@rom1v
Copy link
Collaborator

rom1v commented Aug 26, 2020

Oh, great! Thank you 👍

Is it possible to enable/test it without pushing it on master?

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@dylanmtaylor
Copy link
Author

It have been doing some testing on my fork here https://github.com/dylanmtaylor/scrcpy/actions

@dylanmtaylor
Copy link
Author

I squashed those commits to make it a cleaner merge.

@rom1v
Copy link
Collaborator

rom1v commented Sep 2, 2020

OK, thank you. 👍

Sorry, I currently don't have much time to work on scrcpy. I'd like to investigate the checkstyle issue too.
I have this PR in my TODO, but I cannot say when I have time to check/merge.

But don't worry, I didn't forget, and I have it in mind 😉

@Biswa96
Copy link
Contributor

Biswa96 commented Sep 4, 2020

Just asking. Is it necessary to use docker container to build the project? As far as I have seen, installing packages in GHA does not take too much time.

@dylanmtaylor
Copy link
Author

dylanmtaylor commented Sep 4, 2020

Docker makes the build more reproducible, and you can run in the same container locally as on the CI system, where you cannot easily reproduce the GitHub actions virtual machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants