Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cmd+c/Cmd+c on Mac OS? #642

Closed
rom1v opened this issue Jul 11, 2019 · 6 comments
Closed

Use Cmd+c/Cmd+c on Mac OS? #642

rom1v opened this issue Jul 11, 2019 · 6 comments
Labels

Comments

@rom1v
Copy link
Collaborator

rom1v commented Jul 11, 2019

On Mac OS, should we use Cmd instead of Ctrl to copy-paste?

If yes, we should ifdef the same way we do for the volume:

#ifdef __APPLE__
if (control && !ctrl && meta && !shift) {
#else
if (control && ctrl && !meta && !shift) {
#endif

here:

case SDLK_c:
if (control && ctrl && !meta && !shift && !repeat && down) {
request_device_clipboard(controller);
}
return;
case SDLK_v:
if (control && ctrl && !meta && !repeat && down) {
if (shift) {
// store the text in the device clipboard
set_device_clipboard(controller);
} else {
// inject the text as input events
clipboard_paste(controller);
}
}
return;

@rom1v rom1v added the macos label Jul 11, 2019
@npes87184
Copy link
Contributor

IMO, it should be cmd.

@rom1v
Copy link
Collaborator Author

rom1v commented Jul 12, 2019

OK. Are there any other shortcuts which should use Cmd instead of Ctrl on MacOS?

@npes87184
Copy link
Contributor

In MacOS, (almost) all ctrl should be replaced by cmd.

@carstenhag
Copy link

carstenhag commented Jul 24, 2019

Yeah, on mac I usually only use ctrl on the terminal. Using CMD is way more intuitive for Mac users :)

rom1v added a commit that referenced this issue Jul 31, 2019
rom1v added a commit that referenced this issue Jul 31, 2019
@rom1v
Copy link
Collaborator Author

rom1v commented Jul 31, 2019

Mac users, please test #676 😉 Thank you

rom1v added a commit that referenced this issue Aug 1, 2019
rom1v added a commit that referenced this issue Aug 3, 2019
@rom1v rom1v closed this as completed Apr 11, 2020
@rom1v
Copy link
Collaborator Author

rom1v commented May 30, 2020

Mac users, I would like your opinion on #1446 :)

In macOS applications, do all the app-specific shortcut use Cmd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants