-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate climate_environment MIXS:0001040 #591
Comments
@ramonawalls commented on NMDC microbiomedata/nmdc-schema#586 (comment) Can we check in and confirm we can deprecate this term? |
I think It's good to move forward with this issue's PR. If anybody want substantiating data: As of this month, there are 8991 INSDC Biosamples, out of roughly 40 million, with a Here's the breakdown of annotations that were used at least twice. QuerySELECT
CONCAT(SUBSTRING(content, 1, 72),
CASE
WHEN LENGTH(content) > 75 THEN '...'
ELSE ''
END) AS shortened_content,
count(1)
FROM
main.attributes a
WHERE
harmonized_name = 'climate_environment'
GROUP BY
shortened_content
HAVING
count(1) > 1
ORDER BY
count(1) DESC; Results (`climate_environment` contents have been truncated to 72 characters. Scroll to right to see counts if necessary.)
|
I uploaded mixs-slots-enums-no-MixsCompliantData-domain.json from external-metadata-awareness
It replied Based on the provided information, several other terms in the schema overlap semantically with "climate_environment". These include:
These terms all relate to environmental conditions, weather patterns, or long-term climate factors that overlap semantically with the concept of "climate environment". |
I also asked
|
Well that's not correct.. because treatment columns do capture repetition, duration, and times. Depending on the slot. Regardless, IF there's something not captured it should have a specific slot, shouldn't it have a more specific slot to capture? Not this general catch all. What does "multiple climates" even mean? Intentionality is never captured in slots. |
Thanks for reviewing all that new information/inferences, @mslarae13
I agree! I think the point here is that climate_environment is a treatment slot, which differentiates it from the other 16 slots that Claude found to be semantically similar. Furthermore, removing If you think I have mixed feeling about whether this should be considered a catch-all slot, but I do agree that catch-all slots should be availed.
I think this is highlighting the fact that 'tropical climate;R2/2018-05-11T14:30/2018-05-11T19:30/P1H30M|monsoon climate;R2/2019-05-11T14:30/2019-05-11T19:30/P1H30M'
That may be one of the deepest things I have heard anybody say about MIxS! I asked Claude to elaborate, and it takes the position that all of the If you think the word intentional is a tar pit, then we certainly don't have to use it amongst ourselves. Is one of your points that MIxS doesn't provide a mechanism to capture "I intended to do X, but Y is what really happened?" I.e., that MIxS should only be used to report things that can be confirmed to be true after the fact? I think that's a good plan but maybe we should make sure that is communicated in the documentation. |
Have the developers of these terms been contacted ? |
Discussed with CIG on 2024-09-24. |
Sent an email on Nov 26th |
Sent a followup email today. Term will be deprecated in January. |
Current term details
Please supply the current details of the term that you would like to update:
Suggested update(s)
Please supply the new suggestions for any of the details listed below (only insert text to those details that should be updated):
Additional context
Add any other context about the update request here, e.g. why you think this needs to be updated.
Term is confusing and not used appropriately. After a query of NCBI, the term is often used to describe the biome which should be captured in another field.
Discussed at TWG 2023-06-06
The text was updated successfully, but these errors were encountered: