-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine if and how climate_environment
will be used in the submission schema
#586
Comments
I do think I can check off most of those boxes within a day or two into next week |
GSC's MIxS Specificationfrom https://github.com/GenomicsStandardsConsortium/mixs/blob/main/mixs/excel/mixs_v6.xlsx
BBOP relational version of NCBI biosample_set:select
value,
count(1)
from
all_attribs aa
where
aa.harmonized_name = 'climate_environment'
group by
value
having
count(1) > 1
order by
count(1) desc;
|
Any db.getCollection("biosample_set").find( { climate_environment : { $exists : true } } );
|
climate_environment
will be used in the submission schema
Adding to current sprint per Mark. Need feedback from @mslarae13 |
@turbomam the NCBI examples are quite variable, and not what I'd expect. I am not surprised there's no time or duration for climate manipulation, but rather people just describe the comment. I think , considering the examples we have, this field should just be a way to describe the climate_environment. and not as a "duration of treatment" So from the plant example "tropical climate;R2/2018-05-11T14:30/2018-05-11T19:30/P1H30M" would just be "tropical climate" @turbomam thoughts? |
@mslarae13 That's fine with me. Do you want to allow any string, or would you like to have a validation pattern, or some enumerated values? |
Discussion seems to be ongoing, moving to new sprint |
Name is misleading and should be climate treatment... People are putting biome and other information that should be in a different column here... Ramona suggests deprecating this term. I will put an issue into GSC |
Nearly all of the values in this slot are wrong and should go into one of the ENVO slots (e.g., biome). There is a legitimate need to record information about experimental environmental conditions, but there are either existing slots for that information or we should add new one(s) that are less confusing. I recommend deprecating this term in MIxS and replacing it mostly with existing terms. If there is some environmental data that can't be captured, we can create new terms that are clearer. |
@turbomam Also, we pulled this term into the soil package. It can go away. (GSC only has it in agriculture & plant) @pkalita-lbl FYI |
I'll remove in 7.6.1 |
@turbomam did this get completed? |
Decision: Will deprecate this term. |
I am not sure how to write this example according to the structure. Would like to see some completed examples
Completion
The text was updated successfully, but these errors were encountered: