Installation of completions doesn't use DISTDIR

[alerque]

Having completions installed in nice, and the autoconf setup for configuring the locations seems fine. However the actual installation is broken for distro packagers:

ugrep/Makefile.am

Line 53 in 15adaee

cd $(bashcompletiondir) && \

This assumes you are installing directly to the host system and that these directories existing. Most distro package builds use DESTDIR= or similar mechanisms to install to an isolated location, then package up those files. This scripting ignores DESTDIR entirely.

[alerque]

...this issue partially misdiagnoses the issue because the directories do get created somewhere first, but these ln -s actions are still failing for some reason. I'm looking for the actual reason why.

[alerque]

Updated issue with the actual problem.

[alerque]

Since this is going to affect all the other distros out of there and annoy send every packager on a goose chase to find either the problem or this issue, it might be worth doing a quick patch release before many of them get around to the bump to make downstream lives easier.

[andreasstieger]

Meh, openSUSE is watching. Packagers normally know to check recently reported/closed issues and git changes.

[genivia-inc]

I understand. No worries. The v4.4.1 patch update will be released very soon today.

[barsnick]

Since this is going to affect all the other distros out of there and annoy send every packager on a goose chase to find either the problem or this issue, it might be worth doing a quick patch release before many of them get around to the bump to make downstream lives easier.

Don't worry. I package ugrep myself for Fedora et.al. (because Fedora has fallen asleep), and figured out this problem and the fix within five minutes. You beat me to a pull request.

BTW, advertizing: My package updates to latest, packages completions (separately), packages ugrep-indexer, ... :-)

[carlwgeorge]

@barsnick Package maintainers have day jobs and personal lives, so from time to time a package may lag behind upstream. This doesn't mean that they have "fallen asleep", and it's not nice to claim that's the case. When you notice a package in this state, it's more helpful to send a pull request to update the spec file than it is to advertise your own separate repo. Even better, consider becoming a package maintainer yourself to help with this work more directly.

[genivia-inc]

@carlwgeorge Well said. Package maintainers are busy with their own lives and jobs. Same for many open source developers. Kudos to those who volunteer their time to help! I sincerely hope that package managers receive some acknowledgements and perhaps compliments for their work. I can imagine it can be stressful at times, especially when urgency is requested for critical patches etc.

I try not to release in the weekends or on Fridays. But time management for one person doesn't always align with someone else's time management. I usually have time on Fridays and weekends to get things done that aren't part of my regular job that pays my bills.