Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signed char fix #199

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Signed char fix #199

merged 2 commits into from
Mar 16, 2024

Conversation

mdehling
Copy link
Contributor

Cast chars to unsigned for ctype functions

  • Calling ctype functions (isspace, isalpha, tolower, ...) with arguments neither representable as unsigned char nor equal to EOF is undefined behavior.
  • This fixes issue Build error in examples/braille #198.

@mdehling
Fix debug statement
3c2dd77
@mdehling
Cast chars to unsigned for ctype functions
ef36c16 
- Calling ctype functions (isspace, isalpha, tolower, ...) with
  arguments neither representable as unsigned char nor equal to EOF is
  undefined behavior.
- This commit fixes issue Genivia#198.
genivia-inc
genivia-inc approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@genivia-inc genivia-inc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with casts to call ctype functions. The char_tolower() update is correct.

@genivia-inc genivia-inc merged commit d93790d into Genivia:master Mar 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genivia-inc genivia-inc genivia-inc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdehling @genivia-inc