Check invalid combinations of resolution and registration in load_earth_relief() #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_relief As shown in https://docs.generic-mapping-tools.org/latest/datasets/remote-data.html#id1, `earth_relief_15s` only provides pixel-registered grid, and `earth_relief_03s` and `earth_relief_01s` only provide gridline-registered grid. This PR adds checks for the invalid combination of resolution and registration. A test is also added.
seisman
added
bug
|
A question: do you think we should split the tests in |
|
Deploy preview for pygmt ready! ✅ Preview Built with commit 4a2a002. |
willschlitzer
approved these changes
Feb 26, 2021
willschlitzer
deleted the
earth-relief-invalid-resolution-registration
branch
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…h_relief (GenericMappingTools#965) *Add check to see the registration type when passing a registration type for a specific resolution, and raise an error if an invalid registration is passed. *Add a test to confirm an error is raised when an invalid registration is passed. Co-authored-by: Will Schlitzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As shown in
https://docs.generic-mapping-tools.org/latest/datasets/remote-data.html#id1,
earth_relief_15sonly provides pixel-registered grid, andearth_relief_03sandearth_relief_01sonly providegridline-registered grid.
This PR adds checks for the invalid combination of resolution and
registration. A test is also added.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version