-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write changelog in markdown using MyST #941
Changes from all commits
d4ee476
40c170b
3871496
6058ae0
2491d96
634164b
5bd3cb6
e79592c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,26 +5,29 @@ categories: | |
label: 'feature' | ||
- title: 'Enhancements' | ||
label: 'enhancement' | ||
- title: 'Documentation' | ||
label: 'documentation' | ||
- title: 'Deprecations' | ||
label: 'deprecation' | ||
- title: 'Bug Fixes' | ||
label: 'bug' | ||
- title: 'Documentation' | ||
label: 'documentation' | ||
- title: 'Maintenance' | ||
label: 'maintenance' | ||
- title: 'Deprecations' | ||
label: 'deprecation' | ||
exclude-labels: | ||
- 'skip-changelog' | ||
change-template: '* $TITLE (#$NUMBER)' | ||
category-template: '### $TITLE' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need help to find a way to make the subheaders (e.g. for v0.2.1 enhancements) a proper permalink. I.e. something like https://pygmt-git-myst-changelog.gmt.vercel.app/changes.html#v0-2-1-enhancements instead of https://pygmt-git-myst-changelog.gmt.vercel.app/changes.html#id3 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems commonmark still doesn't support anchors for headers, so maybe we can do nothing here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe do it in sphinx instead? I see https://stackoverflow.com/questions/15394347/adding-a-cross-reference-to-a-subheading-or-anchor-in-another-page#comment79146992_40225340 pointing to https://www.sphinx-doc.org/en/master/usage/extensions/autosectionlabel.html#confval-autosectionlabel_prefix_document. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I don't think it works for us. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @weiji14 As we have no solution for the custom anchors, do you think we should not use h3 headers, but just use bold headings, i.e., use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would stick with h3 headers. Even without the permalink anchors, it'll still be easier for users to navigate quickly to the subsection on the sidebar: And people could still point to the v0.3.0 highlights using https://www.pygmt.org/v0.3.0/changes.html#highlights, and so on for v0.4.0 and beyond. |
||
change-template: '* $TITLE ([#$NUMBER]($URL))' | ||
template: | | ||
[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3781524.svg)](https://doi.org/10.5281/zenodo.3781524) | ||
## Release v$NEXT_PATCH_VERSION (20YY/MM/DD) | ||
|
||
[![Digital Object Identifier for PyGMT v$NEXT_PATCH_VERSION](https://zenodo.org/badge/DOI/10.5281/zenodo.3781524.svg)](https://doi.org/10.5281/zenodo.3781524) | ||
weiji14 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Highlights | ||
### Highlights | ||
|
||
* | ||
|
||
$CHANGES | ||
|
||
## Contributors | ||
### Contributors | ||
|
||
$CONTRIBUTORS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Categories have been reordered following #885 (comment). Do we want to reorder things in the previous release changelogs (i.e. v0.1.0 to v0.3.0) or just keep them as they were?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
No need to reorder the old entries.