Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cylindrical projections to gallery #727

Merged

Conversation

willschlitzer
Copy link
Contributor

Adding cylindrical projections to the projection gallery, as requested in #292.

@seisman seisman added the documentation Improvements or additions to documentation label Dec 11, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 11, 2020
@seisman seisman self-requested a review December 11, 2020 14:45
@seisman
Copy link
Member

seisman commented Dec 12, 2020

@willschlitzer Please mark it "ready for review" if you have finished this PR.

@willschlitzer
Copy link
Contributor Author

@seisman I'm planning on doing separate PRs for each set of figures in the projection gallery. I figure that's a good compromise between a PR for every new file and having just one massive PR for all of the figures. Is that not the best way to go about this?

@seisman
Copy link
Member

seisman commented Dec 12, 2020

It's good to me. PRs with smaller changes also are easier to review.

@willschlitzer willschlitzer marked this pull request as ready for review December 13, 2020 11:13
@seisman seisman merged commit e6d45ec into GenericMappingTools:master Dec 13, 2020
@willschlitzer willschlitzer deleted the cylindrical-projections branch December 13, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants