Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tutorial for adding a map title #720

Merged
merged 14 commits into from
Dec 11, 2020
Merged

Add tutorial for adding a map title #720

merged 14 commits into from
Dec 11, 2020

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Dec 8, 2020 •
edited by seisman
Loading

Adding tutorial for adding a figure title, as requested in #335.

Closes #335.

@weiji14 weiji14 added the documentation Improvements or additions to documentation label Dec 8, 2020
weiji14
weiji14 reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for doing this (and all your other work around PyGMT) @willschlitzer! Always nice to have some fresh eyes on our documentation. Just one minor comment on the backslash syntax for now.

examples/tutorials/frames.py Outdated Show resolved Hide resolved
@willschlitzer
Copy link
Contributor Author

Could I get one of the maintainers to look at my most recent commit? I can't figure out why it failed so many tests and deployment.

@seisman
Copy link
Member

seisman commented Dec 9, 2020

I think it's unrelated to your PR. I just re-triggered the CI jobs.

seisman
seisman reviewed Dec 9, 2020
View reviewed changes
examples/tutorials/frames.py Outdated Show resolved Hide resolved
examples/tutorials/frames.py Show resolved Hide resolved
examples/tutorials/frames.py Outdated Show resolved Hide resolved
@seisman seisman changed the title Add title Add tutorial for adding a map title Dec 9, 2020
@willschlitzer willschlitzer marked this pull request as ready for review December 10, 2020 17:16
@seisman
Copy link
Member

seisman commented Dec 10, 2020 •
edited
Loading

@willschlitzer

It looks good now. Please do two more things:

  1. Merge the master branch, by clicking the "Update branch" button.
  2. Fix the styling issue. You can run make format locally, or you can just write /format in the first line of a comment to automatically format the codes (a feature introduced in Add slash command "/format" to automatically format PRs #646).

@seisman seisman added this to the 0.3.0 milestone Dec 11, 2020
@seisman seisman merged commit 862bd77 into GenericMappingTools:master Dec 11, 2020
@seisman seisman mentioned this pull request Dec 11, 2020
Closed
@willschlitzer willschlitzer deleted the add-title branch December 16, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 left review comments

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

[Easy task if you know some sphinx] Add example for setting map title
3 participants
@willschlitzer @seisman @weiji14