-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "no_clip" to plot, text, contour and meca #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments, otherwise fine.
On a related note, should probably improve the documentation of plot
at https://www.pygmt.org/v0.2.0/api/generated/pygmt.Figure.plot.html#pygmt.Figure.plot since it's quite widely used. I was going to do it in #471 but might be better to have a separate PR handling it specifically.
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, good to merge. The macOS test breakages seem unrelated, not sure why there's a segmentation fault on the xarray shading test?
In PR #650, I added more tests for xarray shading. These tests work well for GMT master, but not for 6.1.1. Perhaps some of the tests have segmentation faults with GMT 6.1.1. |
Description of proposed changes
This PR adds the no_clip argument (alias of -N) to plot, text, countour and meca.
The name no_clip was agreed when wrapping the grdimage method in #620 (comment)
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.