Generalize check figures equal to work with pytest.marks #600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Our
@check_figures_equal
decorator used for comparing two images doesn't work withpytest.mark.parametrize
. These are cherry-picked commits from #560.Changes in this PR are following the cue of matplotlib's
check_figures_equal
decorator. See matplotlib/matplotlib#15199 and matplotlib/matplotlib#17267.Note also issue #579 on how we should really just vendor off the
check_figures_equal
function in the future instead of keeping this bit of code up to date withmatplotlib
.Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.