-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for v0.1.2 #504
Conversation
Patch release in preparation for the Scipy 2020 sprint session.
Also updated MAINTENANCE.md to include the `sed` command, instead of using `vim`.
Release Drafter will now automatically list contributors!
doc/changes.rst
Outdated
|
||
Highlights: | ||
|
||
* Patch release in preparation for the Scipy 2020 sprint session |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Patch release in preparation for the Scipy 2020 sprint session | |
* Patch release in preparation for the SciPy 2020 sprint session |
doc/changes.rst
Outdated
|
||
New Features: | ||
|
||
* Wrap grdcut (`#492 <https://github.com/GenericMappingTools/pygmt/pull/492>`__) @seisman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about removing the authors in each entry? It won't work in reST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll remove it from the Release Drafter yml specification too.
doc/changes.rst
Outdated
@@ -1,6 +1,58 @@ | |||
Changelog | |||
========= | |||
|
|||
Release v0.1.2 (2020/07/XX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to update the date before merging.
Co-Authored-By: Dongdong Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One last thing. We should have done this in v0.1.1, but I feel like we should add @moorepants to the Contributor list for his help on setting up the conda-forge pygmt package. |
Yes, of course. |
Description of proposed changes
Patch release in preparation for the Scipy 2020 sprint session. Preview it live at https://pygmt-git-changelog-v012.gmt.now.sh/changes.html. For reference, the previous changelog is at #445.
Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/master/MAINTENANCE.md#updating-the-changelog. The changelog itself includes the following sections:
TODO:
sed -i.bak -E 's$\(#([0-9]*)\)$(`#\1 <https://github.com/GenericMappingTools/pygmt/pull/\1>`__)$g' changes.rst
.Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.