-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for v0.1.0 #420
Conversation
Changelog style inspired by https://github.com/fatiando/verde. Including highlights, new features, enhancements, documentation, bug fixes, maintenance, deprecations, and list of contributors. Excluded minor pull requests and those that were superseded by later ones. Also update changelog instructions on MAINTENANCE.md and add section on other documentation versions to README.rst.
For historical purposes, to see how far we've come!
Co-Authored-By: Leonardo Uieda <[email protected]>
So that people can navigate to see the pull request details on Github.
* `Development <https://www.pygmt.org/dev>`__ (reflects the *master* branch on | ||
Github) | ||
* `Latest release <https://www.pygmt.org/latest>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder. We might want to switch the HTTP redirect to latest
instead of dev
once v0.1.0 is released.
Using a specific 'Version DOI' in the changelog, and a 'Concept DOI' in the main README page.
Prevents some images in the documentation (like the Zenodo DOI badge) from blowing out of proportion in size.
README.rst
Outdated
.. image:: https://zenodo.org/badge/123456789.svg | ||
:alt: Digital Object Identifier for the Zenodo archive | ||
:target: https://zenodo.org/badge/latestdoi/123456789 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. image:: https://zenodo.org/badge/123456789.svg | |
:alt: Digital Object Identifier for the Zenodo archive | |
:target: https://zenodo.org/badge/latestdoi/123456789 | |
.. image:: https://zenodo.org/badge/123456789.svg | |
:alt: Digital Object Identifier for the Zenodo archive | |
:target: https://zenodo.org/badge/latestdoi/123456789 |
TODO insert correct Concept DOI here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, zenodo provides two types of DOI. Each release has its own doi, and the whole project has a permanent doi which is always resolved to the lastest release.
For example, https://doi.org/10.5281/zenodo.1068342 is the permanent doi for one of my project, and https://doi.org/10.5281/zenodo.3695076 is the doi for the v0.6.6 release.
Perhaps we should use the permanent doi in the README.rst and the release-specific doi in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but right now it's in a draft state and it's only showing me one DOI... I could upload a dummy zipfile and see if that gives me two DOIs? Edit: Nope, tried it and doesn't work. Might just need to change the DOI on the README to the permanent one after releasing v0.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using reserved DOI from Zenodo, and update release date.
Made a release candidate on Zenodo, so that there's now a permanent DOI now that resolves to the latest PyGMT version. Also updated DOI for v0.1.0.
Because the image/url wasn't correct...
Shall we wait for GMT 6.1.0 before merging it and releasing PyGMT 0.1.0? |
When's GMT 6.1.0 going to be released? Probably doesn't matter so much since |
GMT 6.1.0 might be released in the next one or two weeks. |
I kinda want to sort out the pygmt conda package soon for #414. Also we haven't got tests running on GMT 6.1.0, so might be best to put that off until PyGMT v0.2.0? |
I'm OK with that. |
Description of proposed changes
Starting a changelog for PyGMT v0.1.0! Changelog style inspired by fatiando/verde#248. Preview it live at https://pygmt-git-changelog-v010.gmt.now.sh/changes.html. It's quite long (since it's a big release), but please do go over this and let me know if I should add/change anything.
Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/master/MAINTENANCE.md#updating-the-changelog. The changelog itself includes the following sections:
Excluded minor pull requests and those that were superseded by later ones. It's a bit subjective on my part, so let me know if I should add any of the ignored ones listed below back (or throw some entries into the ignored list):
TODO:
%s$#\([0-9]\+\)$`#\1 <https://github.com/GenericMappingTools/pygmt/pull/\1>`__$g
onchanges.rst
. Took me a few minutes to get this right, trick is to use:wq
to write (save changes) and quit.Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.