Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog entry for v0.1.0 #420

Merged
merged 16 commits into from
May 3, 2020
Merged

Changelog entry for v0.1.0 #420

merged 16 commits into from
May 3, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 17, 2020

Description of proposed changes

Starting a changelog for PyGMT v0.1.0! Changelog style inspired by fatiando/verde#248. Preview it live at https://pygmt-git-changelog-v010.gmt.now.sh/changes.html. It's quite long (since it's a big release), but please do go over this and let me know if I should add/change anything.

Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/master/MAINTENANCE.md#updating-the-changelog. The changelog itself includes the following sections:

  • Highlights
  • New features
  • Enhancements
  • Documentation
  • Bug fixes
  • Maintenance
  • Deprecations
  • List of Contributors (sorted by number of commits)

Excluded minor pull requests and those that were superseded by later ones. It's a bit subjective on my part, so let me know if I should add any of the ignored ones listed below back (or throw some entries into the ignored list):

* Add Liam Toney to AUTHORS.md (#415)
* Fix a typo in README.rst (#389)
* Update copyright year to 2020 (#387)
* Minor docs improvements (#386)
* Fix legend typos (#371)
* Fix small typo in disclaimer (#360)
* Quickfix plot docstring to have label (l) (#357)
* Upgrade the minimum required gmt version to 6.0.0rc5 (#351)
* Quickfix min/max elevation for new SRTM15+V2 earth relief grids (#350)
* Fix the wrong example in contributing guide (#334)
* Upgrade gmt from 6.0.0rc1 to 6.0.0rc4 (#327)
* Add Wei Ji to AUTHORS.md (#326)
* Pin sphinx<=1.8.5 to avoid style errors (#306)
* Fix the link of GMT building instructions (#304)
* Fix typos in comments and docstrings (#302)
* Use pandas.read_csv to load tutorial data (#301)
* Use sphinx-gallery 0.3.1 instead of master (#298)
* Upgrade the CI scripts to 1.1.1 (#299)
* Pin version of CI scripts to 1.0.0 (#296)
* Small format fix in the Albers projection example (#295)
* Update travis to latest GMT build script (#287)
* Let get_clib_path find the path to libgmt on Windows (#285)
* Revert "Support Windows" since it's not reviewed
* Support Windows
* Update install instructions for using GMT master (#279)
* Update copyright year in the license (#282)
* Fix copy/paste errors in CONTRIBUTING.md (#283)
* Fix more instances of gmt-python to pygmt (#277)
* Remove unused documentation files (#272)
* Fix more gmt and GMT/Python to PyGMT (#266)
* Update documentation link on the README

TODO:

  • Update changelog instructions on MAINTENANCE.md
  • Add section on other documentation versions to README.rst.
  • Use vim (!!!) to run %s$#\([0-9]\+\)$`#\1 <https://github.com/GenericMappingTools/pygmt/pull/\1>`__$g on changes.rst. Took me a few minutes to get this right, trick is to use :wq to write (save changes) and quit.
  • Add Zenodo DOI link once it's reserved.
  • Add in new Pull Requests merged in for v0.1.0

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Changelog style inspired by https://github.com/fatiando/verde. Including highlights, new features, enhancements, documentation, bug fixes, maintenance, deprecations, and list of contributors. Excluded minor pull requests and those that were superseded by later ones. Also update changelog instructions on MAINTENANCE.md and add section on other documentation versions to README.rst.
@weiji14 weiji14 mentioned this pull request Apr 17, 2020
10 tasks
@weiji14 weiji14 added this to the 0.1.0 milestone Apr 17, 2020
So that people can navigate to see the pull request details on Github.
MAINTENANCE.md Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
doc/changes.rst Outdated Show resolved Hide resolved
Comment on lines +169 to +171
* `Development <https://www.pygmt.org/dev>`__ (reflects the *master* branch on
Github)
* `Latest release <https://www.pygmt.org/latest>`__
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder. We might want to switch the HTTP redirect to latest instead of dev once v0.1.0 is released.

@weiji14 weiji14 marked this pull request as ready for review April 28, 2020 19:44
@weiji14 weiji14 requested a review from seisman April 29, 2020 21:03
Using a specific 'Version DOI' in the changelog, and a 'Concept DOI' in the main README page.
@weiji14
Copy link
Member Author

weiji14 commented Apr 30, 2020

Unsure why the Zenodo DOI badge looks so huge...

Huge Zenodo DOI badge

Edit: Just a CSS styling issue. Fixed.

Prevents some images in the documentation (like the Zenodo DOI badge) from blowing out of proportion in size.
doc/changes.rst Outdated Show resolved Hide resolved
README.rst Outdated
Comment on lines 30 to 32
.. image:: https://zenodo.org/badge/123456789.svg
:alt: Digital Object Identifier for the Zenodo archive
:target: https://zenodo.org/badge/latestdoi/123456789
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. image:: https://zenodo.org/badge/123456789.svg
:alt: Digital Object Identifier for the Zenodo archive
:target: https://zenodo.org/badge/latestdoi/123456789
.. image:: https://zenodo.org/badge/123456789.svg
:alt: Digital Object Identifier for the Zenodo archive
:target: https://zenodo.org/badge/latestdoi/123456789

TODO insert correct Concept DOI here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I've managed to reserve a DOI on Zenodo. Seems like we'll need to make a release and then upload the repository zip/tarball before it becomes active though.

Zenodo DOI reserved image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, zenodo provides two types of DOI. Each release has its own doi, and the whole project has a permanent doi which is always resolved to the lastest release.

For example, https://doi.org/10.5281/zenodo.1068342 is the permanent doi for one of my project, and https://doi.org/10.5281/zenodo.3695076 is the doi for the v0.6.6 release.

Perhaps we should use the permanent doi in the README.rst and the release-specific doi in the changelog.

Copy link
Member Author

@weiji14 weiji14 May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but right now it's in a draft state and it's only showing me one DOI... I could upload a dummy zipfile and see if that gives me two DOIs? Edit: Nope, tried it and doesn't work. Might just need to change the DOI on the README to the permanent one after releasing v0.1.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently what I've filled in on Zenodo. I've listed everyone in our AUTHORS.md file, and Paul on the author list, and also added the NSF funding information.

Zenodo details

Using reserved DOI from Zenodo, and update release date.
Made a release candidate on Zenodo, so that there's now a permanent DOI now that resolves to the latest PyGMT version. Also updated DOI for v0.1.0.
Because the image/url wasn't correct...
@weiji14
Copy link
Member Author

weiji14 commented May 3, 2020

Ok, there's now a 'permanent' PyGMT DOI at DOI after I made a Zenodo-only 'RC' release at DOI. Any remaining issues before I merge this?

@seisman
Copy link
Member

seisman commented May 3, 2020

Shall we wait for GMT 6.1.0 before merging it and releasing PyGMT 0.1.0?

@weiji14
Copy link
Member Author

weiji14 commented May 3, 2020

When's GMT 6.1.0 going to be released? Probably doesn't matter so much since pygmt just wraps around gmt>=6.0.0.

@seisman
Copy link
Member

seisman commented May 3, 2020

GMT 6.1.0 might be released in the next one or two weeks.

@weiji14
Copy link
Member Author

weiji14 commented May 3, 2020

I kinda want to sort out the pygmt conda package soon for #414. Also we haven't got tests running on GMT 6.1.0, so might be best to put that off until PyGMT v0.2.0?

@seisman
Copy link
Member

seisman commented May 3, 2020

I'm OK with that.

@weiji14 weiji14 merged commit 74501e0 into master May 3, 2020
@weiji14 weiji14 deleted the changelog/v0.1.0 branch May 3, 2020 04:50
@leouieda
Copy link
Member

leouieda commented May 4, 2020

Thanks for handling this @weiji14 and @seisman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants