Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text accepting "frame" as an argument #385

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Allow text accepting "frame" as an argument #385

merged 1 commit into from
Dec 5, 2019

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 5, 2019

Description of proposed changes

fig.text() should accept "frame" as an argument.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman requested review from weiji14 and leouieda December 5, 2019 04:41
@seisman seisman merged commit fff0d5c into master Dec 5, 2019
@seisman seisman deleted the text-frame branch December 5, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants