Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog entry for v0.14.0 #3730

Merged
merged 31 commits into from
Dec 31, 2024
Merged

Changelog entry for v0.14.0 #3730

merged 31 commits into from
Dec 31, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 28, 2024

Description of proposed changes

This PR adds the changelog entry for v0.14.0.

Checklist

  • Add a new entry in doc/_static/version_switch.js for documentation switcher
  • Add the version to the compatibility table doc/minversions.md
  • Update citation information CITATION.cff and BibTeX at https://github.com/GenericMappingTools/pygmt#citing-pygmt
    • Update authorship list if necessary
    • Update DOI (and URL for BibTeX)
    • Update version
    • Update date released
    • Update the BibTeX key
  • Copy the draft release note from https://github.com/GenericMappingTools/pygmt/releases to doc/changes.md
  • Edit the changelog to look nice (see maintainers guide for details)
    • Add the separator --- between the old and new changelog sections
    • Update the release date and the DOI badge in doc/changes.md
    • Edit the list of people who contributed to the release, linking to their GitHub account. Sort their names by the number of commits made since the last release (e.g., use git shortlog HEAD...v0.13.0 -sne)
    • Edit the change list to remove any trivial changes (updates to the README, typo fixes, CI configuration, etc)
    • Update with any remaining PRs merged before release
    • Add highlights

@seisman seisman added this to the 0.14.0 milestone Dec 28, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 28, 2024
@seisman seisman added help wanted Helping hands are appreciated needs review This PR has higher priority and needs review. labels Dec 28, 2024
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
CITATION.cff Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output of git shortlog -sne at commit 1256d15, trimmed to those with >=3 commits (after merging some names).

  1051  Dongdong Tian <[email protected]>
   276  Yvonne Fröhlich <[email protected]>
   264  dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
   261  Wei Ji <[email protected]>
   256  Leonardo Uieda <[email protected]>
   192  Will Schlitzer <[email protected]>
   145  Michael Grund <[email protected]>
   110  Max Jones <[email protected]>
    33  Yao Jiayuan <[email protected]>
    15  Liam Toney <[email protected]>
     7  yohaimagen <[email protected]>
     5  Tong <[email protected]>
     3  Andre L. Belem <[email protected]>
     3  kmaterna <[email protected]>

Do we want to re-arrange any positions?

Copy link
Member Author

@seisman seisman Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub contributors page (https://github.com/GenericMappingTools/pygmt/graphs/contributors) shows totally different numbers of commits, likely because GitHub also takes co-authorship into consideration. I feel these numbers (including the numbers of additions and deletions) make more sense.

Currently, the author order is,

Tian, Uieda, Leong, Fröhlich, Schlitzer, Grund, Jones, Toney, Yao, Magen, Tong, Materna, Belem, Anant, Ziebarth, Quinn, Wessel.

Considering that Leo is no longer active, maybe

Tian, Leong, Fröhlich, Schlitzer, Grund, Uieda, ...

BTW, I just found that Jing-Hui Tong's given/family names are incorrectly swapped and have fixed it in 895bbfe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of moving Leo's name to the end too, when we decide to remove Paul's name (#3425 (comment)). We'll probably need to update the authorship policy before doing this, so let's keep those positions intact for now.

Thanks for spotting Jing-Hui's incorrect name order... Btw, I think we could move her up one spot given her contributions during the AGU24 workshop?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could move her up one spot given her contributions during the AGU24 workshop?

Sounds reasonable. Done in 894fe93.

Copy link
Member

@yvonnefroehlich yvonnefroehlich Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, moving Jing-Hui up in the author order is definitely fair.

doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
@seisman seisman marked this pull request as ready for review December 30, 2024 20:30
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Dec 31, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman, pre-approving for now, but wait for 2nd or 3rd approval. Changelog could use maybe 1 more highlight (one recommendation below, but ok with any other one).

I'll be on a trip with spotty internet connection for the next 48hrs-ish, so won't be able to get to the forum announcement until 3rd Jan or so. But don't need to wait for me if it looks good.

doc/changes.md Outdated Show resolved Hide resolved
@seisman seisman removed help wanted Helping hands are appreciated final review call This PR requires final review and approval from a second reviewer labels Dec 31, 2024
@seisman seisman merged commit 2a84b5e into main Dec 31, 2024
10 checks passed
@seisman seisman deleted the changelog/v0.14.0 branch December 31, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants