Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Pin rasterio < 1.4.3 temporarily #3668

Merged
merged 2 commits into from
Dec 3, 2024
Merged

CI: Pin rasterio < 1.4.3 temporarily #3668

merged 2 commits into from
Dec 3, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 3, 2024

As reported in #3301 (comment), rasterio 1.4.3 causes GDAL driver issues.

This PR pins to rasterio<1.4.3 as a workaround.

@seisman seisman added run/benchmark Trigger the benchmark workflow in PRs run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels Dec 3, 2024
weiji14
weiji14 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the tests are failing deterministically now (unlike in Jun 2024) 😂 I'll need to make sure this doesn't affect the AGU24 workshop conda environment...

.github/workflows/ci_tests_dev.yaml Outdated Show resolved Hide resolved
@seisman seisman changed the title CI: Pin rasterio < 1.4.3 CI: Pin rasterio < 1.4.3 temporarily Dec 3, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs and removed run/benchmark Trigger the benchmark workflow in PRs run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels Dec 3, 2024
@seisman seisman added this to the 0.14.0 milestone Dec 3, 2024
@seisman seisman merged commit 7845e9e into main Dec 3, 2024
25 checks passed
@seisman seisman deleted the rasterio/1.4.3 branch December 3, 2024 04:13
seisman added a commit that referenced this pull request Dec 3, 2024
@seisman
Revert "CI: Pin rasterio < 1.4.3 temporarily (#3668)"
2fc8566 
This reverts commit 7845e9e.
@seisman seisman mentioned this pull request Dec 3, 2024
Merged
seisman added a commit that referenced this pull request Dec 3, 2024
@seisman
CI: Pin rasterio < 1.4.3 temporarily (#3668)
e191f56
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @weiji14