List function aliases in a more compact layout #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
doc/alias-style
branch
from
eed215e to
f13e735
Compare
seisman
added
needs review
seisman
changed the title
seisman
changed the title
|
Could you try 3 columns instead of 4? The columns seem to go too close to the edge of the browser window on a less wide window (e.g. when I have two windows side by side).
|
seisman
commented
Dec 3, 2024
|
Readthedocs build failing because of #3301 (comment) 😅 Docs build isn't broken yet, probably due to caching, but it'll probably break on newer PRs. |
|
With 3 columns it looks good to me. Makes the whole thing also better readable in my opinion since you dont have to scroll down for long lists. |
weiji14
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in the screenshot below (the left one), currently, the function aliases are listed vertically, wasting a lot of vertical spaces. This PR uses the
hlistdirective to make the list more compact, by listing 4 items per row (the right one).Preview: https://pygmt-dev--3666.org.readthedocs.build/en/3666/api/generated/pygmt.Figure.basemap.html