Figure.savefig: Add a new test for the show parameter and simplify existing tests. #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
seisman
commented
Oct 31, 2024
•
seisman
commented
- Get rid of try-except in test_figure_savefig_geotiff
- Simplify test_figure_savefig with unittest.mock
- Add one more test for Figure.savefig(show=True) [Increase code coverage to 98.74%]
seisman
added
maintenance
seisman
added
final review call
seisman
removed
the
final review call
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
…isting tests. (#3568) * Get rid of try-except in test_figure_savefig_geotiff * Simplify test_figure_savefig_unknown_extension * Simplify test_figure_savefig with unittest.mock * Add one more test for Figure.savefig(show=True)
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
…isting tests. (#3568) * Get rid of try-except in test_figure_savefig_geotiff * Simplify test_figure_savefig_unknown_extension * Simplify test_figure_savefig with unittest.mock * Add one more test for Figure.savefig(show=True)
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
…isting tests. (#3568) * Get rid of try-except in test_figure_savefig_geotiff * Simplify test_figure_savefig_unknown_extension * Simplify test_figure_savefig with unittest.mock * Add one more test for Figure.savefig(show=True)
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
…isting tests. (#3568) * Get rid of try-except in test_figure_savefig_geotiff * Simplify test_figure_savefig_unknown_extension * Simplify test_figure_savefig with unittest.mock * Add one more test for Figure.savefig(show=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.