Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Change "Pandas" to "pandas" #3525

Merged
merged 3 commits into from
Oct 17, 2024
Merged

DOC: Change "Pandas" to "pandas" #3525

merged 3 commits into from
Oct 17, 2024

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

Change Pandas to pandas to be consistent with the pandas documentation.
For context: #3475 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Oct 16, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.14.0 milestone Oct 16, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Oct 16, 2024
@seisman
Copy link
Member

seisman commented Oct 16, 2024

I'm OK with the changes. There are still a few files to be updated:

  • .github/workflows/ci_tests_dev.yaml
  • .github/workflows/ci_tests.yaml
  • .github/ISSUE_TEMPLATE/4-release_checklist.md

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 16, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 17, 2024
@seisman seisman merged commit 17fcb4c into main Oct 17, 2024
22 of 23 checks passed
@seisman seisman deleted the write-pandas-lowercase branch October 17, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants