Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating External Resources: Add tutorial in Portuguese and using PyGMT in Google Colab #3360

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

andrebelem
Copy link
Contributor

@andrebelem andrebelem commented Jul 30, 2024

This is an update for External Resources

  • a PyGMT webinar conducted in Portuguese

As suggested in the forum, I am applying to include this webinar in Portuguese for PyGMT.

Preview: https://pygmt-dev--3360.org.readthedocs.build/en/3360/external_resources.html

This is an update for a PyGMT webinar conducted in Portuguese.
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrebelem Cool, this is a nice addition to this collection and especially interesting for the non-English speaking world. Thanks 🙂!

doc/external_resources.md Outdated Show resolved Hide resolved
@@ -12,6 +12,16 @@ to submit a pull request with your recommended addition to the

:::::{grid} 1 2 2 3

::::{grid-item-card} 2024 PyGMT Webinar using Google Colab (in Portuguese)
:link: [[https://www.generic-mapping-tools.org/egu22pygmt](https://github.com/andrebelem/Oficina_PyGMT)/](https://github.com/andrebelem/Oficina_PyGMT)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humm...how can I change this ? The construction is wrong. It should be:
link: https://github.com/andrebelem/Oficina_PyGMT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like my suggestion from the code review. Are you able / allowed to click the "Commit suggestion" button, which is just below my inital review comment? Then you can apply my suggestion directly:

github_review_commit_suggestion

Of course you can also make a new commit with the correct link and push to this branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap. I did it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title to make it more descriptive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: "Introduction to Geospatial Data Exploration with PyGMT in Google Colab (in Portuguese)"?

Should I create a new pull request?

Copy link
Member

@yvonnefroehlich yvonnefroehlich Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, the PR changes are fine!
I am sorry, my comment was probably confusing 🙁. It's only about the title of the PR. You can change it via the "edit" button on the right:
title_pr

Maybe something like "External Resources: Add tutorial in Portuguese "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. I changed the title. Thanks.

Co-authored-by: Yvonne Fröhlich <[email protected]>
@yvonnefroehlich yvonnefroehlich added the enhancement Improving an existing feature label Jul 30, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.13.0 milestone Jul 30, 2024
@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation and removed enhancement Improving an existing feature labels Jul 30, 2024
@andrebelem andrebelem changed the title Update external_resources.md Updating External Resources: Add tutorial in Portuguese and using PyGMT in Google Colab Jul 30, 2024
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing these resources!

@yvonnefroehlich yvonnefroehlich added the final review call This PR requires final review and approval from a second reviewer label Jul 30, 2024
@seisman seisman merged commit 3ac074c into GenericMappingTools:main Jul 31, 2024
10 checks passed
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants