Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove pytest-xdist and pytest-rerunfailures options from addopts and only add them in CI jobs #3267

Merged
merged 2 commits into from
May 22, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented May 22, 2024

Description of proposed changes

In PR #3193, pytest-xdist and pytest-rerunfailures were added to speed up the CI jobs. They work well but also cause some troubles:

  1. Options -n auto --reruns 2 are added to addopts, so pytest-xdist and pytest-rerunfailures are required in local environments.
  2. In local environments, I (maybe also others) usually don't run the full tests and only run a few specific tests, but pytest-xdist's -n auto option always initializes multiple workers, which takes more time when running a single test.

This PR removes the options -n auto --reruns 2 from pyproject.toml and add the options to the workflows if needed.

@seisman seisman added maintenance Boring but important stuff for the core devs run/benchmark Trigger the benchmark workflow in PRs run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels May 22, 2024
@seisman seisman added this to the 0.13.0 milestone May 22, 2024
@seisman seisman added needs review This PR has higher priority and needs review. and removed run/benchmark Trigger the benchmark workflow in PRs run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels May 22, 2024
@seisman seisman merged commit 7bd57d5 into main May 22, 2024
15 checks passed
@seisman seisman deleted the patch/pytest-xdist branch May 22, 2024 22:39
@seisman seisman removed the needs review This PR has higher priority and needs review. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants