-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function build_arg_list for building arguments list from keyword dictionaries #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
enhancement
Improving an existing feature
needs review
This PR has higher priority and needs review.
labels
Mar 31, 2024
10 tasks
Co-authored-by: Yvonne Fröhlich <[email protected]>
michaelgrund
approved these changes
Apr 2, 2024
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Apr 7, 2024
weiji14
reviewed
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code logic ok, just some suggestions related to the type hints.
Co-authored-by: Wei Ji <[email protected]>
weiji14
approved these changes
Apr 8, 2024
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes of commit 1149b37 in PR #3132.
In this PR, a new utility function
build_arg_list
function is added. The new function is modified from thebuild_arg_string
function and it differs from thebuild_arg_string
function in the following aspects:non_ascii_to_octal
function to the single-letter option arguments, not to the configuration arguments and input/output filesThe goal is to replace
build_arg_string
withbuild_arg_list
in all module wrappers and deprecate/removebuild_arg_string
in future releases.PR #3132 contains more changes that we will apply after this PR is merged.