Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.call_module: Support passing a list of argument strings #3139

Merged
merged 11 commits into from
Mar 31, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 26, 2024

Description of proposed changes

See #3132 for context. This PR enhances the Session.call_module() method to support passing a list of argument strings to the GMT_Call_Module API function.

PR #3132 contains changes that should be made after this PR is merged.

@seisman seisman added enhancement Improving an existing feature needs review This PR has higher priority and needs review. labels Mar 26, 2024
@seisman seisman added this to the 0.12.0 milestone Mar 26, 2024
@seisman seisman force-pushed the call-module-arglist branch from 53c0991 to 8c9b058 Compare March 26, 2024 04:17
pygmt/clib/session.py Outdated Show resolved Hide resolved
pygmt/tests/test_clib.py Outdated Show resolved Hide resolved
pygmt/clib/session.py Outdated Show resolved Hide resolved
pygmt/clib/session.py Outdated Show resolved Hide resolved
@seisman seisman requested a review from a team March 30, 2024 08:42
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. final review call This PR requires final review and approval from a second reviewer labels Mar 31, 2024
@seisman seisman merged commit bbf909d into main Mar 31, 2024
20 of 21 checks passed
@seisman seisman deleted the call-module-arglist branch March 31, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants