Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.virtualfile_to_dataset: Add 'header' parameter to parse column names from table header #3117

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 18, 2024

Address #2730 (comment).

Add the header parameter to parse column names from table header. It's behavior is similar to the pd.read_csv's header parameter.

@seisman seisman force-pushed the gmtdataset/header branch from 6bbcc79 to 1f03cfe Compare March 30, 2024 11:53
@seisman seisman changed the title POC: Parse column names from data header GMT_DATASET: Add 'header' parameter to parse column names from table header Mar 30, 2024
@seisman seisman marked this pull request as ready for review March 30, 2024 11:56
@seisman seisman changed the title GMT_DATASET: Add 'header' parameter to parse column names from table header Session.virtualfile_to_dataset: Add 'header' parameter to parse column names from table header Mar 30, 2024
@seisman seisman added enhancement Improving an existing feature needs review This PR has higher priority and needs review. labels Mar 30, 2024
@seisman seisman added this to the 0.12.0 milestone Mar 30, 2024
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 7, 2024
@seisman
Copy link
Member Author

seisman commented Apr 10, 2024

/format

@seisman
Copy link
Member Author

seisman commented Apr 17, 2024

/format

@seisman seisman merged commit 1746c04 into main Apr 18, 2024
19 checks passed
@seisman seisman deleted the gmtdataset/header branch April 18, 2024 12:20
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants