-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygmt.filter1d: Improve performance by storing output in virtual files #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
documentation
Improvements or additions to documentation
needs review
This PR has higher priority and needs review.
labels
Mar 4, 2024
seisman
force-pushed
the
docstrings/output_type
branch
from
March 8, 2024 14:26
a991908
to
8857ce6
Compare
seisman
changed the title
Improve the docstrings of 'output_type' and 'outfile'
pygmt.filter1d: Improve performance by getting rid of temporary files
Mar 8, 2024
seisman
added
run/benchmark
Trigger the benchmark workflow in PRs
and removed
documentation
Improvements or additions to documentation
labels
Mar 8, 2024
CodSpeed Performance ReportMerging #3085 will not alter performanceComparing Summary
Benchmarks breakdown
|
This was referenced Mar 11, 2024
seisman
force-pushed
the
docstrings/output_type
branch
from
March 11, 2024 14:37
6f83cf9
to
26c46cd
Compare
seisman
force-pushed
the
docstrings/output_type
branch
from
March 11, 2024 14:42
26c46cd
to
f39d2d4
Compare
seisman
force-pushed
the
docstrings/output_type
branch
from
March 11, 2024 14:51
f39d2d4
to
92dc36a
Compare
Benchmarks:
Main branch:
This branch:
|
seisman
changed the title
pygmt.filter1d: Improve performance by getting rid of temporary files
pygmt.filter1d: Improve performance using virtual files instead of temporary files for output
Mar 12, 2024
seisman
added
maintenance
Boring but important stuff for the core devs
needs review
This PR has higher priority and needs review.
labels
Mar 12, 2024
michaelgrund
approved these changes
Mar 12, 2024
michaelgrund
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Mar 12, 2024
seisman
changed the title
pygmt.filter1d: Improve performance using virtual files instead of temporary files for output
pygmt.filter1d: Improve performance by storing output in virtual files
Mar 13, 2024
seisman
removed
final review call
This PR requires final review and approval from a second reviewer
run/benchmark
Trigger the benchmark workflow in PRs
labels
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://pygmt-dev--3085.org.readthedocs.build/en/3085/api/generated/pygmt.filter1d.html#pygmt.filter1d
Similar to #3097.