Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery example showing how to adjust line segment ends (caps and joints) #3015

Merged
merged 20 commits into from
Jan 27, 2024

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Jan 19, 2024

Description of proposed changes

This PR aims to add a gallery example showing how to adjust line segment ends (caps and joints).

Orientated on the upstream GMT example: https://docs.generic-mapping-tools.org/dev/reference/features.html#tbl-penex

Preveiw: https://pygmt-dev--3015.org.readthedocs.build/en/3015/gallery/lines/line_segment_ends.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added the documentation Improvements or additions to documentation label Jan 19, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Jan 19, 2024
@yvonnefroehlich yvonnefroehlich marked this pull request as draft January 19, 2024 07:46
@yvonnefroehlich yvonnefroehlich changed the title Add gallery example showing how to adjust line segment ends (caps and joints) WIP: Add gallery example showing how to adjust line segment ends (caps and joints) Jan 19, 2024
@yvonnefroehlich
Copy link
Member Author

/format

@yvonnefroehlich
Copy link
Member Author

/format

@seisman seisman added this to the 0.11.0 milestone Jan 23, 2024
examples/gallery/lines/line_segment_ends.py Outdated Show resolved Hide resolved
examples/gallery/lines/line_segment_ends.py Outdated Show resolved Hide resolved
examples/gallery/lines/line_segment_ends.py Outdated Show resolved Hide resolved
@yvonnefroehlich yvonnefroehlich changed the title WIP: Add gallery example showing how to adjust line segment ends (caps and joints) Add gallery example showing how to adjust line segment ends (caps and joints) Jan 26, 2024
@yvonnefroehlich yvonnefroehlich marked this pull request as ready for review January 26, 2024 08:28
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jan 26, 2024
@seisman seisman merged commit 7347418 into main Jan 27, 2024
8 of 9 checks passed
@seisman seisman deleted the add-gallery-line-ends branch January 27, 2024 03:11
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants