-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.coast/pygmt.select/pygmt.grdlandmask: Use long names ("crude"/"low"/"intermediate"/"high"/"full") for the 'resolution' parameter #3013
base: main
Are you sure you want to change the base?
Changes from all commits
44f983f
4fae745
5fac3ae
5e1ebe8
2cbe6c9
e24bbd8
1267a9c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,18 +2,20 @@ | |
grdlandmask - Create a "wet-dry" mask grid from shoreline data base | ||
""" | ||
|
||
from typing import Literal | ||
|
||
import xarray as xr | ||
from pygmt.clib import Session | ||
from pygmt.exceptions import GMTInvalidInput | ||
from pygmt.helpers import build_arg_list, fmt_docstring, kwargs_to_strings, use_alias | ||
from pygmt.src._common import _parse_coastline_resolution | ||
|
||
__doctest_skip__ = ["grdlandmask"] | ||
|
||
|
||
@fmt_docstring | ||
@use_alias( | ||
A="area_thresh", | ||
D="resolution", | ||
E="bordervalues", | ||
I="spacing", | ||
N="maskvalues", | ||
|
@@ -23,7 +25,11 @@ | |
x="cores", | ||
) | ||
@kwargs_to_strings(I="sequence", R="sequence", N="sequence", E="sequence") | ||
def grdlandmask(outgrid: str | None = None, **kwargs) -> xr.DataArray | None: | ||
def grdlandmask( | ||
outgrid: str | None = None, | ||
resolution: Literal["full", "high", "intermediate", "low", "crude", None] = None, | ||
**kwargs, | ||
) -> xr.DataArray | None: | ||
r""" | ||
Create a grid file with set values for land and water. | ||
|
||
|
@@ -44,17 +50,14 @@ def grdlandmask(outgrid: str | None = None, **kwargs) -> xr.DataArray | None: | |
{spacing} | ||
{region} | ||
{area_thresh} | ||
resolution : str | ||
*res*\[\ **+f**\]. Select the resolution of the data set to use | ||
((**f**)ull, (**h**)igh, (**i**)ntermediate, (**l**)ow, or | ||
(**c**)rude). The resolution drops off by ~80% between data sets. | ||
[Default is **l**]. Append **+f** to automatically select a lower | ||
resolution should the one requested not be available | ||
[abort if not found]. Alternatively, choose (**a**)uto to automatically | ||
select the best resolution given the chosen region. Note that because | ||
the coastlines differ in details a node in a mask file using one | ||
resolution is not guaranteed to remain inside [or outside] when a | ||
different resolution is selected. | ||
resolution | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copied from https://docs.generic-mapping-tools.org/dev/grdlandmask.html#d, but the |
||
Ignored unless ``mask`` is set. Select the resolution of the coastline dataset | ||
to use. The available resolutions from highest to lowest are: ``"full"``, | ||
``"high"``, ``"intermediate"``, ``"low"``, and ``"crude"``, which drops by 80% | ||
between levels. Note that because the coastlines differ in details a node in a | ||
mask file using one resolution is not guaranteed to remain inside [or outside] | ||
when a different resolution is selected. If ``None``, the low resolution is used | ||
by default. | ||
bordervalues : bool, str, float, or list | ||
Nodes that fall exactly on a polygon boundary should be | ||
considered to be outside the polygon [Default considers them to be | ||
|
@@ -98,6 +101,10 @@ def grdlandmask(outgrid: str | None = None, **kwargs) -> xr.DataArray | None: | |
if kwargs.get("I") is None or kwargs.get("R") is None: | ||
raise GMTInvalidInput("Both 'region' and 'spacing' must be specified.") | ||
|
||
kwargs["D"] = kwargs.get( | ||
"D", _parse_coastline_resolution(resolution, allow_auto=True) | ||
) | ||
|
||
with Session() as lib: | ||
with lib.virtualfile_out(kind="grid", fname=outgrid) as voutgrd: | ||
kwargs["G"] = voutgrd | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
use_alias, | ||
validate_output_table_type, | ||
) | ||
from pygmt.src._common import _parse_coastline_resolution | ||
|
||
__doctest_skip__ = ["select"] | ||
|
||
|
@@ -22,7 +23,6 @@ | |
@use_alias( | ||
A="area_thresh", | ||
C="dist2pt", | ||
D="resolution", | ||
F="polygon", | ||
G="gridmask", | ||
I="reverse", | ||
|
@@ -48,6 +48,7 @@ def select( | |
data=None, | ||
output_type: Literal["pandas", "numpy", "file"] = "pandas", | ||
outfile: str | None = None, | ||
resolution: Literal["full", "high", "intermediate", "low", "crude", None] = None, | ||
**kwargs, | ||
) -> pd.DataFrame | np.ndarray | None: | ||
r""" | ||
|
@@ -116,16 +117,13 @@ def select( | |
<reference/file-formats.html#optional-segment-header-records>` | ||
*polygonfile*. For spherical polygons (lon, lat), make sure no | ||
consecutive points are separated by 180 degrees or more in longitude. | ||
resolution : str | ||
*resolution*\ [**+f**]. | ||
Ignored unless ``mask`` is set. Selects the resolution of the coastline | ||
data set to use ((**f**)ull, (**h**)igh, (**i**)ntermediate, (**l**)ow, | ||
or (**c**)rude). The resolution drops off by ~80% between data sets. | ||
[Default is **l**]. Append (**+f**) to automatically select a lower | ||
resolution should the one requested not be available [Default is abort | ||
if not found]. Note that because the coastlines differ in details | ||
it is not guaranteed that a point will remain inside [or outside] when | ||
a different resolution is selected. | ||
resolution | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copied from https://docs.generic-mapping-tools.org/dev/gmtselect.html#d, but the |
||
Ignored unless ``mask`` is set. Select the resolution of the coastline dataset | ||
to use. The available resolutions from highest to lowest are: ``"full"``, | ||
``"high"``, ``"intermediate"``, ``"low"``, and ``"crude"``, which drops by 80% | ||
between levels. Note that because the coastlines differ in details it is not | ||
guaranteed that a point will remain inside [or outside] when a different | ||
resolution is selected. If ``None``, the low resolution is used by default. | ||
gridmask : str | ||
Pass all locations that are inside the valid data area of the grid | ||
*gridmask*. Nodes that are outside are either NaN or zero. | ||
|
@@ -205,6 +203,8 @@ def select( | |
>>> # longitudes 246 and 247 and latitudes 20 and 21 | ||
>>> out = pygmt.select(data=ship_data, region=[246, 247, 20, 21]) | ||
""" | ||
kwargs["D"] = kwargs.get("D", _parse_coastline_resolution(resolution)) | ||
|
||
output_type = validate_output_table_type(output_type, outfile=outfile) | ||
|
||
column_names = None | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from https://docs.generic-mapping-tools.org/dev/coast.html#d, but the +f modifier is not mentioned at all, since it's rarely used. It may not work as documented since in recent GMT versions, GMT can automatically download GSHHG and DCW datasets from the GMT data server.