-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery example for plotting connection lines ("connection" parameter of Figure.plot) #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
the
documentation
Improvements or additions to documentation
label
Jan 14, 2024
yvonnefroehlich
changed the title
Add gallery example for plotting connection lines (
Add gallery example for plotting connection lines ("connection" parameter of Figure.plot)
Jan 14, 2024
connection
parameter of Figure.plot
)
/format |
seisman
reviewed
Jan 18, 2024
The Docs Preview link should work with the fix in PR #3014. |
michaelgrund
approved these changes
Jan 18, 2024
michaelgrund
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Jan 18, 2024
seisman
approved these changes
Jan 19, 2024
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds a gallery example for plotting connection lines via the
connection
parameter ofFigure.plot
.The code is already a bit older (~ Nov or Dec 2023). So, I have make some adjustments:
"
directives ra, rt, rs, r10/35 and na
" to"
directives pa, pt, ps, p10/35 and na
"-F flage of plot: Update figure caption corresponding to GMT 6.5 gmt#8299
Preview: https://pygmt-dev--2999.org.readthedocs.build/en/2999/gallery/lines/connection_lines.html
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code