Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery example for plotting connection lines ("connection" parameter of Figure.plot) #2999

Merged
merged 11 commits into from
Jan 19, 2024

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Jan 14, 2024

Description of proposed changes

This PR adds a gallery example for plotting connection lines via the connection parameter of Figure.plot.

The code is already a bit older (~ Nov or Dec 2023). So, I have make some adjustments:

Preview: https://pygmt-dev--2999.org.readthedocs.build/en/2999/gallery/lines/connection_lines.html

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added the documentation Improvements or additions to documentation label Jan 14, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Jan 14, 2024
@yvonnefroehlich yvonnefroehlich marked this pull request as draft January 14, 2024 20:31
@yvonnefroehlich yvonnefroehlich changed the title Add gallery example for plotting connection lines (connection parameter of Figure.plot) Add gallery example for plotting connection lines ("connection" parameter of Figure.plot) Jan 14, 2024
@yvonnefroehlich
Copy link
Member Author

/format

@yvonnefroehlich yvonnefroehlich marked this pull request as ready for review January 16, 2024 17:34
@yvonnefroehlich yvonnefroehlich marked this pull request as draft January 16, 2024 17:35
@yvonnefroehlich yvonnefroehlich marked this pull request as ready for review January 17, 2024 19:31
@seisman
Copy link
Member

seisman commented Jan 18, 2024

The Docs Preview link should work with the fix in PR #3014.

@seisman seisman added this to the 0.11.0 milestone Jan 18, 2024
@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 18, 2024
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 18, 2024
@seisman seisman merged commit de00b71 into main Jan 19, 2024
8 of 9 checks passed
@seisman seisman deleted the add-gallery-connection branch January 19, 2024 04:35
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants