CI: Run "GMT Dev Tests" if PR is labeled with 'run/test-gmt-dev' #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
added
run/test-gmt-dev
weiji14
approved these changes
Jan 7, 2024
.github/workflows/ci_tests_dev.yaml
Outdated
| # | ||
| name: GMT Dev Tests | ||
|
|
||
| on: | ||
| # push: | ||
| # branches: [ main ] | ||
| pull_request: | ||
| types: [ready_for_review] | ||
| types: [ labeled, synchronize ] |
There was a problem hiding this comment.
+1 to this. We originally set "GMT Dev Tests" to run when the PR is ready for review in PR #831, but that might have been a bit of a waste of CI resources to be honest.
There was a problem hiding this comment.
I've changed the types to types: [ opened, reopened, labeled, synchronize ], following PR #2958.
Comment on lines
21
to
-27
| **Slash Commands** | ||
|
|
||
| You can write slash commands (`/command`) in the first line of a comment to perform | ||
| specific operations. Supported slash commands are: | ||
| specific operations. Supported slash command is: | ||
|
|
||
| - `/format`: automatically format and lint the code | ||
| - `/test-gmt-dev`: run full tests on the latest GMT development version |
There was a problem hiding this comment.
Similar to my comment at #2958 (comment), should we still document this somewhere so that contributors/maintainers know to request that the run/test-gmt-dev label gets added to PRs that require it? Or just rely on maintainers to know when to set the label?
There was a problem hiding this comment.
weiji14
added
final review call
seisman
commented
Jan 7, 2024
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Similar to #2958.
Slash command
/test-gmt-devis no longer supported. To enable the "GMT Dev Tests" workflow, just add therun/test-gmt-devlabel (needs written permission to this repository).