Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a duplicate fixture for pandas dtypes including pyarrow types #2941

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jan 2, 2024

Description of proposed changes

Explicitly copying the numpy dtypes fixture in test_clib_virtualfiles.py to a new dtypes_pandas fixture that includes pyarrow types, so that modifications to the original numpy dtypes fixture won't affect other tests.

Fixes #2936 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Explicitly copying the numpy dtypes fixture to a new pandas dtypes fixture that includes pyarrow types, so that modifications to the original numpy dtypes fixture won't affect other tests.
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Jan 2, 2024
@weiji14 weiji14 added this to the 0.11.0 milestone Jan 2, 2024
@weiji14 weiji14 self-assigned this Jan 2, 2024
@weiji14 weiji14 marked this pull request as ready for review January 2, 2024 06:16
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Jan 2, 2024
@weiji14 weiji14 enabled auto-merge (squash) January 2, 2024 06:18
@weiji14 weiji14 merged commit 6028bf4 into main Jan 2, 2024
16 of 19 checks passed
@weiji14 weiji14 deleted the dtypes_pandas branch January 2, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants