Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainers guides #2916

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Update maintainers guides #2916

merged 6 commits into from
Dec 28, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 26, 2023

@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Dec 26, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 26, 2023
doc/maintenance.md Outdated Show resolved Hide resolved
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 27, 2023
@seisman
Copy link
Member Author

seisman commented Dec 27, 2023

@weiji14 Do you want to add a section like "Continuous Benchmark" to this guide?

@weiji14
Copy link
Member

weiji14 commented Dec 27, 2023

@weiji14 Do you want to add a section like "Continuous Benchmark" to this guide?

I did think about it when writing the docs in #2908, but wasn't sure what to include yet in terms of guidelines. Maybe after a few weeks/months when we've got some experience with benchmarking, then we can add some words in.

@seisman
Copy link
Member Author

seisman commented Dec 27, 2023

@weiji14 Do you want to add a section like "Continuous Benchmark" to this guide?

I did think about it when writing the docs in #2908, but wasn't sure what to include yet in terms of guidelines. Maybe after a few weeks/months when we've got some experience with benchmarking, then we can add some words in.

Sounds good.

doc/maintenance.md Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 28, 2023
@seisman seisman merged commit d292e30 into main Dec 28, 2023
9 checks passed
@seisman seisman deleted the doc/maintenance branch December 28, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants