Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.timestamp: Improve an existing test to check floating-point offset #2889

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 17, 2023

Description of proposed changes

Modify an existing test to make sure that arguments like offset=4, offset=(4, 1) work as expected.

Copy link
Contributor

github-actions bot commented Dec 17, 2023

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_timestamp_offset.png

Image diff(s)

Added images

Modified images

Path Old New
test_timestamp_offset.png

Report last updated at commit 41bf443

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Dec 17, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 17, 2023
@seisman
Copy link
Member Author

seisman commented Dec 20, 2023

Wait for GMT 6.5.0 first as mentioned in #2694 (comment).

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Dec 22, 2023
@seisman seisman merged commit 753ab4a into main Jan 8, 2024
9 of 15 checks passed
@seisman seisman deleted the test/timestamp branch January 8, 2024 04:21
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants