-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.shift_origin: Improve docstrings, add inline examples and add type hints #2879
Conversation
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
Ping @GenericMappingTools/pygmt-maintainers Since we're working on the As mentioned in the updated docstrings:
So, by default Personally, I prefer to Here are gallery examples that use
|
CodSpeed Performance ReportMerging #2879 will not alter performanceFalling back to comparing Summary
|
I'd prefer to explicitly use |
OK. Updated one instance in 7ece697. |
Only passing the value is nice because of shortness and data type. But I feel for the examples, it is better to keep the unit because:
|
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
Description of proposed changes
Preview: https://pygmt-dev--2879.org.readthedocs.build/en/2879/api/generated/pygmt.Figure.shift_origin.html