-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let kwargs_to_strings work with default values and positional arguments #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
kwargs-to-strings-improved
branch
2 times, most recently
from
November 22, 2023 13:33
f6d64b7
to
ac04502
Compare
seisman
force-pushed
the
kwargs-to-strings-improved
branch
from
November 22, 2023 13:47
ac04502
to
ea046d2
Compare
Co-authored-by: Michael Grund <[email protected]>
seisman
removed
enhancement
Improving an existing feature
needs review
This PR has higher priority and needs review.
labels
Dec 15, 2023
I've merged this PR without review and approval so that I can work on other issues that need the changes in this PR. |
yvonnefroehlich
changed the title
Let kwargs_to_strings work with default values and postional arguments
Let kwargs_to_strings work with default values and positional arguments
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #2361 for the original issue report. The solution comes from https://stackoverflow.com/a/69170441.
In summary, it's possible to use the following codes to get the default values of parameters:
Here are some example codes to understand the behavior the the above codes, in which case 3 is usually how we call PyGMT functions/methods:
The outputs are:
This PR will fix #2361. With changes in this PR, now we don't need to manually deal with
offset
inFigure.timestamp
(see#2208),
panel
insubplot
(3edb1ee) andfname
inpygmt.which
(#2726).Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version