Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Japanese "PyGMT-HOWTO" tutorial to "External Resources" #2743

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Oct 13, 2023

Description of proposed changes

This PR aims to add the the Japanese "PyGMT-HOWTO" tutorial to External Resources.

Website: https://tktmyd.github.io/pygmt-howto-jp/pygmt.html
Repository: https://github.com/tktmyd/pygmt-howto-jp

Fixes #2727

Preview: https://pygmt-dev--2743.org.readthedocs.build/en/2743/external_resources.html#tutorials

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation enhancement Improving an existing feature feature Brand new feature labels Oct 13, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.11.0 milestone Oct 13, 2023
@seisman seisman added first-timers-only For absolute beginners final review call This PR requires final review and approval from a second reviewer and removed enhancement Improving an existing feature feature Brand new feature first-timers-only For absolute beginners labels Oct 13, 2023
@seisman seisman merged commit b7b11c5 into main Oct 14, 2023
7 checks passed
@seisman seisman deleted the add-external-jap-tut-maeda branch October 14, 2023 07:16
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Japanese "PyGMT-HOWTO" tutorial to "External Resources"
2 participants