Figure.savefig: Support uppercase file extensions (e.g., PNG, PDF) #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
commented
Sep 20, 2023
| @@ -306,7 +306,7 @@ def savefig( | |||
|
|
|||
| fname = Path(fname) | |||
| prefix, suffix = fname.with_suffix("").as_posix(), fname.suffix | |||
| ext = suffix[1:] # Remove the . | |||
| ext = suffix[1:].lower() # Remove the . and normalize to lowercase | |||
There was a problem hiding this comment.
I don't update the docstrings to document this new enhancement because I don't want to encourage users to use uppercase file extensions.
There was a problem hiding this comment.
I agree that the use of upper case file extensions (including any combination of lower and upper case letters) should be avoided. Thus, I feel it is fine to not explicitly mention this possibility in the documentation.
seisman
added
final review call
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Closes #2683
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version