Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery example "Quoted lines" (style="q") #2563

Merged
merged 25 commits into from
Jul 3, 2023
Merged

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Jun 4, 2023

Description of proposed changes

This PR aims to add a gallery example showing how to generated "Quoted lines".

Upstream GMT documentation: https://docs.generic-mapping-tools.org/dev/plot.html#s

Related to:

Preview: https://pygmt-dev--2563.org.readthedocs.build/en/2563/gallery/lines/quoted_lines.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added the documentation Improvements or additions to documentation label Jun 4, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.10.0 milestone Jun 4, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Jun 4, 2023
@yvonnefroehlich
Copy link
Member Author

/format

@yvonnefroehlich yvonnefroehlich marked this pull request as draft June 4, 2023 15:29
@yvonnefroehlich yvonnefroehlich changed the title WIP: Add gallery example "Quoted lines" WIP: Add gallery example "Quoted lines" (style="q") Jun 4, 2023
@yvonnefroehlich yvonnefroehlich added the needs review This PR has higher priority and needs review. label Jun 27, 2023
@yvonnefroehlich yvonnefroehlich changed the title WIP: Add gallery example "Quoted lines" (style="q") Add gallery example "Quoted lines" (style="q") Jun 28, 2023
@yvonnefroehlich yvonnefroehlich marked this pull request as ready for review June 28, 2023 05:59
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jun 29, 2023
@seisman seisman requested a review from a team July 2, 2023 02:28
examples/gallery/lines/quoted_lines.py Outdated Show resolved Hide resolved
examples/gallery/lines/quoted_lines.py Outdated Show resolved Hide resolved
@seisman seisman merged commit 301b222 into main Jul 3, 2023
@seisman seisman deleted the add-gallery-quotedlines branch July 3, 2023 08:56
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants