clib.Session: Wrap the GMT_Get_Common API function #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
enhancement
seisman
commented
Apr 18, 2023
seisman
commented
Apr 18, 2023
michaelgrund
approved these changes
Apr 18, 2023
seisman
added
final review call
|
Hopefully, this PR can get another review before I merge it @GenericMappingTools/pygmt-maintainers |
weiji14
reviewed
Apr 21, 2023
seisman
commented
Apr 21, 2023
weiji14
reviewed
Apr 21, 2023
weiji14
reviewed
Apr 21, 2023
| - ``"a"``: geometry of the dataset (int) | ||
| - ``"b"``: return 0 if `-bi` was set and 1 if `-bo` was set (int) | ||
| - ``"f"``: return 0 if `-fi` was set and 1 if `-fo` was set (int) | ||
| - ``"h"``: whether to delete existing header records (int) |
There was a problem hiding this comment.
Looking at https://docs.generic-mapping-tools.org/6.4/gmt.html#h-full, is this just checking whether -h+d was set?
Co-authored-by: Wei Ji <[email protected]>
weiji14
approved these changes
Apr 21, 2023
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Wrap the
GMT_Get_CommonAPI function.Wrapping this function is a necessary step toward addressing other issues/enhancements:
Figure.tilemapsupport syntax likeregion="JP"Add Figure.tilemap to plot XYZ tile maps #2394 (comment)