Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Figure.shift_origin to a standalone Python file #2485

Merged
merged 3 commits into from
Apr 9, 2023
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 8, 2023

Description of proposed changes

Move the codes of Figure.shift_origin from pygmt/figure.py to pygmt/src/shift_origin.py.

This is the first PR for #2401.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman force-pushed the shift-origin/move branch from 6fe414c to ae95dee Compare April 8, 2023 04:16
@seisman seisman added this to the 0.10.0 milestone Apr 8, 2023
@seisman seisman added enhancement Improving an existing feature needs review This PR has higher priority and needs review. labels Apr 8, 2023
pygmt/src/shift_origin.py Outdated Show resolved Hide resolved
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 9, 2023
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman seisman merged commit ba5cb77 into main Apr 9, 2023
@seisman seisman deleted the shift-origin/move branch April 9, 2023 15:43
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 9, 2023
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants