Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated incols parameter from Figure.text (deprecated since v0.8.0) #2473

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

This PR removes the deprecated incols parameter from Figure.text (deprecated since v0.8.0).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the deprecation Deprecating a feature label Apr 3, 2023
@michaelgrund michaelgrund added this to the 0.10.0 milestone Apr 3, 2023
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was quite fast! Should be fine.

@michaelgrund michaelgrund added the final review call This PR requires final review and approval from a second reviewer label Apr 4, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 6, 2023
@seisman seisman merged commit 203ef7e into main Apr 6, 2023
@seisman seisman deleted the text-rem-depr-incols branch April 6, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants