Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog entry for v0.9.0 #2469

Merged
merged 14 commits into from
Mar 31, 2023
Merged

Changelog entry for v0.9.0 #2469

merged 14 commits into from
Mar 31, 2023

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Mar 30, 2023

Description of proposed changes

This PR adds the changelog entry for v0.9.0.

Preview at https://pygmt-dev--2469.org.readthedocs.build/en/2469/changes.html

Related to issue #2424

Previous release v0.8.0 at #2272

TODO

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

README.rst Outdated Show resolved Hide resolved
@seisman seisman added this to the 0.9.0 milestone Mar 30, 2023
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 30, 2023
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
@maxrjones maxrjones changed the title WIP: Changelog entry for v0.9.0 Changelog entry for v0.9.0 Mar 31, 2023
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxrjones! Hopefully someone can take another look before we merge this. I've got a crazy weekend schedule, but will try to help out as much as I can on Monday NZ time (which is practically Sunday UTC).

doc/changes.md Outdated Show resolved Hide resolved
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Mar 31, 2023
@maxrjones
Copy link
Member Author

Thanks @maxrjones! Hopefully someone can take another look before we merge this. I've got a crazy weekend schedule, but will try to help out as much as I can on Monday NZ time (which is practically Sunday UTC).

I put March 31 on the release issue, but if you prefer we wait until Sunday UTC (April 02) that's totally fine with me. I could update the dates in this PR. I originally suggested Friday expecting to be away this weekend, but that's actually not the case.

Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except minor edits.

doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
@maxrjones
Copy link
Member Author

The last couple commits have led to failures on the windows CI. Does anyone know if those are a barrier to releasing on this commit?

@weiji14
Copy link
Member

weiji14 commented Mar 31, 2023

The last couple commits have led to failures on the windows CI. Does anyone know if those are a barrier to releasing on this commit?

Seems to be just on the WIndows - Python 3.8 build. Let's try a simple re-run first in case it's just a random failure.

@weiji14
Copy link
Member

weiji14 commented Mar 31, 2023

Ok, builds pass now. Feel free to ship it @maxrjones 🚀🚀🚀

@maxrjones maxrjones merged commit 1d8944f into main Mar 31, 2023
@maxrjones maxrjones deleted the release-v0.9.0 branch March 31, 2023 20:21
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 31, 2023
@weiji14 weiji14 mentioned this pull request Mar 31, 2023
36 tasks
@weiji14 weiji14 mentioned this pull request Aug 31, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants