Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing plot3d_projection test #2415

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix the failing plot3d_projection test #2415

merged 1 commit into from
Mar 13, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 13, 2023

Description of proposed changes

The test_plot3d_projection test fails for the GMT master branch. The error messages are:

----------------------------- Captured stderr call -----------------------------
Error: [ERROR]: Western boundary is > 180 degrees from specified central meridian and thus your region is invalid
Error: [ERROR]: General map projection error

Based on the comments in GenericMappingTools/gmt#7295 (comment), I think the central meridian is incorrectly given in this test.

This PR changed the central meridian to be the center of the specified region.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 13, 2023
@seisman seisman added this to the 0.9.0 milestone Mar 13, 2023
@seisman seisman marked this pull request as draft March 13, 2023 02:40
@seisman seisman marked this pull request as ready for review March 13, 2023 02:40
@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_plot3d_projection.png

Image diff(s)

Added images

Modified images

Path Old New
test_plot3d_projection.png

Report last updated at commit e1559a1

@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 13, 2023
@seisman seisman removed the needs review This PR has higher priority and needs review. label Mar 13, 2023
@seisman seisman merged commit 8575cc0 into main Mar 13, 2023
@seisman seisman deleted the fix-plot3d-projection branch March 13, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants