-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Colorbar gallery example for categorical data #2395
Conversation
Co-authored-by: Michael Grund <[email protected]>
# Colorbar position justified outside map frame (J) at Middle Right (MR), | ||
# Colorbar placed outside figure frame (J) at Middle Right (MR), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion "figure" is not correct here, since the whole object is the figure, including the area outside the map frame where the colorbar is placed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. My intention to change it was that the generated figure is no geographical map. Maybe "plot" would serve as a more general term? But I am not sure whether there is a clear differentiation between "plot" and "figure". Thus, I changed it back to "map" in commit 29a7bb7.
Description of proposed changes
This PR aims to extend the Colorbar gallery example to show a colorbar suitable for categorical data.
Related to: #2357 (comment)
Currently the modified output figure looks like:
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version