-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend Mambaforge and mamba in the installation and contributing guides #2385
Conversation
@@ -128,30 +128,23 @@ want): | |||
|
|||
.. tab-set:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At line 120, we have:
First, we must configure conda to get packages from the conda-forge channel
conda config --prepend channels conda-forge
This line is not necessary if users use Mambaforge + mamba, but are required if users use conda or install mamba in other ways.
I'm unsure if we should remove these lines and always add the --channel conda-forge
option to conda
/mamba
commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention that this step is not needed if Mambaforge
is used? Or we could just leave it, since running this command under Mambaforge doesn't hurt actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we could just leave it, since running this command under Mambaforge doesn't hurt actually.
Sounds good to me.
@@ -128,30 +128,23 @@ want): | |||
|
|||
.. tab-set:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention that this step is not needed if Mambaforge
is used? Or we could just leave it, since running this command under Mambaforge doesn't hurt actually.
Since `mamba` is recommended over `conda` as per #2385.
Update a few more `conda` references to `mamba` in the main README and other locations that were missed out in #2385.
Update a few more `conda` references to `mamba` in the main README and other locations that were missed out in #2385.
Description of proposed changes
Preview:
Fixes #2368
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version