Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.ternary: Fix the crash for pd.DataFrame input with GMT 6.3-6.4 #2274

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 26, 2022

Description of proposed changes

See #2138 for the related issue.

Figure.ternary crashes for a pd.DataFrame input with GMT 6.3-6.4. This PR fixes the crash by converting pd.DataFrame to NumPy array as mentioned in #2138 (comment).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added bug Something isn't working upstream Bug or missing feature of upstream core GMT labels Dec 26, 2022
@seisman seisman added this to the 0.8.0 milestone Dec 26, 2022
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 26, 2022
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Bug or missing feature of upstream core GMT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants