-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set gridline (if available) as the default grid registration for remote datasets #2266
Merged
Merged
Changes from 4 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
39203d5
update default registration for load_earth_relief
willschlitzer dd1b685
update default registration for load_earth_age
willschlitzer dcb09b5
Merge branch 'main' into load-remote-dataset/set-default-registration
seisman 5d649e6
Update pygmt/datasets/load_remote_dataset.py
seisman ead76a0
Merge branch 'main' into load-remote-dataset/set-default-registration
willschlitzer 24b8931
change if statement for default registration
willschlitzer bdfc550
add default registration testing for test_datasets_earth_age.py
willschlitzer 7b0a219
update earth_age registration docstring
willschlitzer 2fefe64
update earth_free_air_anomaly registration docstring
willschlitzer 3442893
update test_datasets_earth_free_air_anomaly.py for default registration
willschlitzer d36f53d
update registration docstring in earth_geoid.py
willschlitzer 24b3e73
add test to test_datasets_earth_geoid.py for default registration
willschlitzer 2a64cf5
update registration docstring in earth_magnetic_anomaly.py
willschlitzer eaa57ae
add test to test_datasets_earth_magnetic_anomaly.py for default regis…
willschlitzer 040883e
update registration docstring in earth_vertical_gravity_gradient.py
willschlitzer 79ca10e
run make format
willschlitzer 664d7da
add test for default registration to test_datasets_earth_vertical_gra…
willschlitzer c7fa8f5
update registration docstring to earth_relief.py
willschlitzer 7ec384d
remove note in earth_relief.py
willschlitzer 1fadc26
add tests for loading default registrations for 15s and 03s to test_d…
willschlitzer 6f306fd
run make format
willschlitzer e24bcbc
Update pygmt/datasets/load_remote_dataset.py
willschlitzer 087e6a9
remove test_earth_age_05m_with_region from test_datasets_earth_age.py
willschlitzer 75519f7
remove test_earth_faa_05m_with_region from test_datasets_earth_free_a…
willschlitzer f668947
remove test_earth_geoid_05m_with_region from test_datasets_earth_geoi…
willschlitzer 78fc8c1
remove test_earth_mag_05m_with_region from test_datasets_earth_magnet…
willschlitzer ae6176d
remove test_earth_vertical_gravity_gradient_05m_with_region from test…
willschlitzer 3714ccc
remove test_earth_relief_05m_with_region from test_datasets_earth_rel…
willschlitzer 9bfb317
uncomment pull_request for cache data
willschlitzer bea25d5
recomment pull_request for cache data
willschlitzer 05f79a1
Apply suggestions from code review
willschlitzer 8b09c33
Apply suggestions from code review
willschlitzer 6a984e5
Merge branch 'main' into load-remote-dataset/set-default-registration
willschlitzer 60c1eee
remove 05m mag4km test
willschlitzer 224bbcf
change 05m to 01m resolution in test_datasets_earth_magnetic_anomaly.py
willschlitzer c624d43
change 05m to 01m resolution in test_datasets_earth_age.py
willschlitzer cad7796
change 05m to 01m resolution in test_datasets_earth_free_air_anomaly.py
willschlitzer 706c5bc
change 05m to 01m resolution in test_datasets_earth_geoid.py
willschlitzer 9cb34ec
change 05m to 01m resolution in test_datasets_earth_relief.py
willschlitzer 6235bab
change 05m to 01m resolution in test_datasets_earth_vertical_gravity_…
willschlitzer f3fc043
Merge branch 'main' into load-remote-dataset/set-default-registration
willschlitzer f8553d5
Apply suggestions from code review
willschlitzer a2e508d
run make format
willschlitzer cedfa26
Always check if gridline is the default registration for 01d resolution
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed my mind and now I think your solution in #1929 (comment) is better, because it's more clear that "gridline" is the default registration.
In either case, I also think we should put
gridline
beforepixel
, because letterg
is in front of letterp
andgridline
andpixel
are internally represented as 0 and 1 in GMT.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I will be back on December 26 and can update the PR then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel these changes should be done in a separate PR so that this PR is smaller and easier to review.
Edit: Done in #2276.