Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_earth_geoid function for Earth Geoid dataset #2236

Merged
merged 15 commits into from
Dec 9, 2022

Conversation

willschlitzer
Copy link
Contributor

This adds the load_earth_geoid function to load the EGM2008 Earth Geoid remote dataset.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label Dec 7, 2022
@willschlitzer willschlitzer added this to the 0.8.0 milestone Dec 7, 2022
@willschlitzer willschlitzer self-assigned this Dec 7, 2022
pygmt/datasets/earth_geoid.py Outdated Show resolved Hide resolved
pygmt/datasets/load_remote_dataset.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_earth_geoid.py Outdated Show resolved Hide resolved
@willschlitzer willschlitzer changed the title WIP: Add load_earth_geoid function for Earth Geoid dataset Add load_earth_geoid function for Earth Geoid dataset Dec 8, 2022
@willschlitzer willschlitzer marked this pull request as ready for review December 8, 2022 13:45
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 8, 2022
@seisman
Copy link
Member

seisman commented Dec 9, 2022

@willschlitzer Need to resolve the conflicts after merging #2196

@willschlitzer
Copy link
Contributor Author

I just pushed a change for the magnetic anomaly cache files, as there were previously no commas after earth_mag_01d_g.grd and S90W180.earth_mag_05m_g.grd. It didn't cause any problems in #2196 (as far as I can tell), but should I rerun caching in this to make sure the appropriate files have been cached?

@seisman
Copy link
Member

seisman commented Dec 9, 2022

I just pushed a change for the magnetic anomaly cache files, as there were previously no commas after earth_mag_01d_g.grd and S90W180.earth_mag_05m_g.grd. It didn't cause any problems in #2196 (as far as I can tell), but should I rerun caching in this to make sure the appropriate files have been cached?

I think it's fine.

@seisman seisman merged commit 772f3f7 into main Dec 9, 2022
@seisman seisman deleted the load-remote-dataset/earth-geoid branch December 9, 2022 11:40
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 9, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants