-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage of z value in ternary dataset #2227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgrund
added
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
labels
Dec 5, 2022
/format |
I can't access the Matlab file so can't verify it.
Please submit an upstream fix first. |
seisman
reviewed
Dec 6, 2022
4 tasks
/format |
Co-authored-by: Yvonne Fröhlich <[email protected]>
seisman
approved these changes
Dec 9, 2022
seisman
added
the
final review call
This PR requires final review and approval from a second reviewer
label
Dec 9, 2022
willschlitzer
approved these changes
Dec 9, 2022
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Dec 10, 2022
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Yvonne Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Just noticed that @yvonnefroehlich made an overlooked comment right before PR #2211 was merged in.
I double checked this point and indeed the convention was not correct. Additonally, the z value of the table (permittivity) is used in the gallery example in PR #2138 for coloring. Also a point which we should change in upstream GMT although it's only an example dataset to show the usage of ternary plots.
#2223 needs to be merged first before adding the
permittivity
column to tests.Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version